[sr-dev] sip_trace() broken in master

[Juha Heinanen]

Daniel-Constantin Mierla writes:

> Can you try with latest master? I pushed a commit that hopefully fixes
> it.

It works now.

> On the other hand, the use of flag looks like no longer necessary if
> tracing mode parameter is set to 't'. Would it be acceptable to just add
> a new function sip_trace_mode() that will accept one parameter to
> specify what to track (message, transaction, dialog)? It would be a
> short form of sip_trace() with 3 parameters, when the two are not
> needed. I think it would be more coherent for the future to get rid of
> using also the message flag for tracking the transaction.

For me it would be best and simplest if tracing of all request and
responses would happen automatically when siptrace module is loaded and
suitable parameters are set and when tracing is turned on via an rpc
command, i.e., without any function calls in the config.

If that cannot be achived and a function call is needed, one must be
enough.

-- Juha