[sr-dev] siptrace warning

[Daniel-Constantin Mierla]

Hello,

that is via the mode param of the sip_trace() function -- is not
considering the trace_flag/setflag() option of marking the traffic for
tracing?

We can make the init log message debug and check if dialog api was
loaded if sip_trace() mode is 'd', printing error at that level.

Cheers,
Daniel

On 09.09.19 09:43, Henning Westerholt wrote:
> Hello,
>
> I think the way it is documented (with a dedicated mode for the dialog 
> tracing functionality) it should not be active if the dialog tracing 
> parameter is not used. I just quickly looked into the code, but it seems 
> to be the implemented like this.
>
> Cheers,
>
> Henning
>
>
> Am 09.09.19 um 08:39 schrieb Daniel-Constantin Mierla:
>> Hello,
>>
>> I made that warning an info message (commit
>> ce19d9212feb0ff4b017b5eaa71e4637a71aa4b9), but I am considering to add a
>> param to be able to control if dialog tracking should be done. I didn't
>> have time to dig much into it, but I do not want tracking of dialog
>> automatically if dialog module is loaded -- if that's the case, it
>> should be a way to disable it. This is a new feature for 5.3, so it
>> should be tuned to match existing behavior.
>>
>> Cheers,
>> Daniel
>>
>> On 09.09.19 08:07, Juha Heinanen wrote:
>>> Henning Westerholt writes:
>>>
>>>> just to understand it correctly:
>>>>
>>>> - is the dialog module loaded and acc generates the warning nevertheless?
>>>>
>>>> - is the dialog module not loaded, but you don't use the dialog
>>>> functionality of acc?
>>> Dialog module is not loaded and I'm not tracing dialogs.
>>>
>>> -- Juha
>>>
>>> _______________________________________________
>>> Kamailio (SER) - Development Mailing List
>>> sr-dev at lists.kamailio.org
>>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda