[sr-dev] [kamailio/kamailio] nathelper: test sdp c line and sip source ip address is matched. (#2045)

Henning Westerholt notifications at github.com
Tue Sep 3 23:37:46 CEST 2019


I merged your pull request, with some adaptions. I removed the white-space changes from the docs.

The nat_uac_test function return 1 when a NAT check matches for all existing checks and -1 otherwise. So i also adapted the check to work like this. A second reason for the change was that the way it was implemented  would stop working if another new flag would be added later on. I also adapted the c function return codes to the other existing code. 

The additionally discussed functionality to also return the number of matches lines could be easily exported as a dedicated function. This could be done with a small wrapper like the existing function is_rfc1918.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#issuecomment-527650756
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190903/531b244c/attachment.html>


More information about the sr-dev mailing list