[sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: closing mnl_socket in some exceptional situations (#2114)

Henning Westerholt notifications at github.com
Thu Oct 31 16:55:27 CET 2019


I looked into the existing code of the function create_ipsec_tunnel(..)

Are you sure that the "return 0" in the error cases is correct? Should it not be -1, as in the one case in the bottom of the function? If yes - then it makes probably sense to combine them all into one "goto error" case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2114#issuecomment-548443605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20191031/1c49f6a3/attachment.html>


More information about the sr-dev mailing list