[sr-dev] git:5.3:aa875e29: xmlrpc: clean allocated buffer for reply when no more memory for reason value

Daniel-Constantin Mierla miconda at gmail.com
Mon Oct 7 11:02:07 CEST 2019


Module: kamailio
Branch: 5.3
Commit: aa875e297bea05828f319d71fc68c44969931231
URL: https://github.com/kamailio/kamailio/commit/aa875e297bea05828f319d71fc68c44969931231

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2019-10-07T10:52:41+02:00

xmlrpc: clean allocated buffer for reply when no more memory for reason value

(cherry picked from commit 36a4b16117d79f1a30a9f929350f75ab8bfd5d2a)

---

Modified: src/modules/xmlrpc/xmlrpc.c

---

Diff:  https://github.com/kamailio/kamailio/commit/aa875e297bea05828f319d71fc68c44969931231.diff
Patch: https://github.com/kamailio/kamailio/commit/aa875e297bea05828f319d71fc68c44969931231.patch

---

diff --git a/src/modules/xmlrpc/xmlrpc.c b/src/modules/xmlrpc/xmlrpc.c
index 9521af2386..7552b4d7f1 100644
--- a/src/modules/xmlrpc/xmlrpc.c
+++ b/src/modules/xmlrpc/xmlrpc.c
@@ -2509,7 +2509,7 @@ static int ki_xmlrpc_reply(sip_msg_t* msg, int rcode, str* reason)
 	reply.reason = as_asciiz(reason);
 	if (reply.reason == NULL) {
 		ERR("No memory left\n");
-		return -1;
+		goto error;
 	}
 
 	if (reply.code >= 300) {




More information about the sr-dev mailing list