[sr-dev] git:master:c0381899: crypto: remove FIXME, add proper log level for debug statement, rephrase log

Henning Westerholt hw at skalatan.de
Wed Oct 2 16:30:32 CEST 2019


Module: kamailio
Branch: master
Commit: c03818998f0bd679a1db67ef3b487dd7f1ec256b
URL: https://github.com/kamailio/kamailio/commit/c03818998f0bd679a1db67ef3b487dd7f1ec256b

Author: Henning Westerholt <hw at skalatan.de>
Committer: Henning Westerholt <hw at skalatan.de>
Date: 2019-10-02T16:29:46+02:00

crypto: remove FIXME, add proper log level for debug statement, rephrase log

---

Modified: src/modules/crypto/crypto_uuid.c

---

Diff:  https://github.com/kamailio/kamailio/commit/c03818998f0bd679a1db67ef3b487dd7f1ec256b.diff
Patch: https://github.com/kamailio/kamailio/commit/c03818998f0bd679a1db67ef3b487dd7f1ec256b.patch

---

diff --git a/src/modules/crypto/crypto_uuid.c b/src/modules/crypto/crypto_uuid.c
index 86a6aa66ff..a4049e6282 100644
--- a/src/modules/crypto/crypto_uuid.c
+++ b/src/modules/crypto/crypto_uuid.c
@@ -218,9 +218,8 @@ int crypto_generate_SHA1(str* in, str* hash)
 
 	void* ret;
 	if ((ret=SHA1((unsigned char *)in->s, in->len, crypto_buf)) != crypto_buf) {
-		LM_ERR("SHA1 algo failed!\n");
-		/* FIXME remove LM_BUG */
-		LM_BUG("Pointer value %p\n", ret);
+		LM_ERR("SHA1 algorithm failed!\n");
+		LM_DBG("return value from library %p\n", ret);
 		return -1;
 	}
 




More information about the sr-dev mailing list