[sr-dev] git:5.3:3eac2726: utils: Change sh(1) "test ==" usage to "="
Henning Westerholt
hw at skalatan.de
Fri Nov 29 18:43:04 CET 2019
Module: kamailio
Branch: 5.3
Commit: 3eac27269bb60ec062eb0c2058319c70a94e0fbb
URL: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c70a94e0fbb
Author: Greg Troxel <gdt at lexort.com>
Committer: Henning Westerholt <hw at skalatan.de>
Date: 2019-11-29T18:42:52+01:00
utils: Change sh(1) "test ==" usage to "="
The POSIX sh(1) specification says that strings are compared with
test(1) (also "[") with "=". Bash accepts "==" and this leads to
non-portable code. This commit simply changes "==" within test/[ to
"=".
(cherry picked from commit e8b8251f6c7382f8e373c2b309422973a3bf730d)
---
Modified: utils/kamctl/kamdbctl
---
Diff: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c70a94e0fbb.diff
Patch: https://github.com/kamailio/kamailio/commit/3eac27269bb60ec062eb0c2058319c70a94e0fbb.patch
---
diff --git a/utils/kamctl/kamdbctl b/utils/kamctl/kamdbctl
index f291228180..f9d48c9b4e 100755
--- a/utils/kamctl/kamdbctl
+++ b/utils/kamctl/kamdbctl
@@ -153,7 +153,7 @@ kamailio_dump() # pars: <database name>
merr "kamailio_dump function takes two param"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_dump $1 $2
elif [ "$PW" = "" ] ; then
$DUMP_CMD $1 > $2
@@ -174,7 +174,7 @@ kamailio_restore() #pars: <database name> <filename>
merr "kamailio_restore function takes two params"
exit 1
fi
- if [ "$USED_DBENGINE" == "oracle" ]; then
+ if [ "$USED_DBENGINE" = "oracle" ]; then
oracle_restore $1 $2
else
sql_query $1 < $2
@@ -290,7 +290,7 @@ kamailio_pframework() #pars: <action>
case $1 in
copy)
# copy database to some other name
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -323,7 +323,7 @@ case $1 in
exit $ret
;;
backup)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
@@ -337,7 +337,7 @@ case $1 in
exit $?
;;
restore)
- if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
+ if [ "$USED_DBENGINE" = "berkeley" -o "$USED_DBENGINE" = "dbtext" ] ; then
merr "$USED_DBENGINE don't support this operation"
exit 1
fi
More information about the sr-dev
mailing list