[sr-dev] git:master:cb41fc36: nat_traversal: remove not needed (and redundant) str trim implementation

Henning Westerholt hw at skalatan.de
Sat Nov 23 23:23:35 CET 2019


Module: kamailio
Branch: master
Commit: cb41fc36a123d1fc3f9b30368ecd37ffa88c0730
URL: https://github.com/kamailio/kamailio/commit/cb41fc36a123d1fc3f9b30368ecd37ffa88c0730

Author: Henning Westerholt <hw at skalatan.de>
Committer: Henning Westerholt <hw at skalatan.de>
Date: 2019-11-23T23:14:16+01:00

nat_traversal: remove not needed (and redundant) str trim implementation

---

Modified: src/modules/nat_traversal/nat_traversal.c

---

Diff:  https://github.com/kamailio/kamailio/commit/cb41fc36a123d1fc3f9b30368ecd37ffa88c0730.diff
Patch: https://github.com/kamailio/kamailio/commit/cb41fc36a123d1fc3f9b30368ecd37ffa88c0730.patch

---

diff --git a/src/modules/nat_traversal/nat_traversal.c b/src/modules/nat_traversal/nat_traversal.c
index 7bf0ae8c02..709b9032cd 100644
--- a/src/modules/nat_traversal/nat_traversal.c
+++ b/src/modules/nat_traversal/nat_traversal.c
@@ -730,34 +730,6 @@ static bool Dialog_Param_add_candidate(Dialog_Param *param, char *candidate)
 // Miscellaneous helper functions
 //
 
-// returns str with leading whitespace removed
-static INLINE void ltrim(str *string)
-{
-	while(string->len > 0 && isspace((int)*(string->s))) {
-		string->len--;
-		string->s++;
-	}
-}
-
-// returns str with trailing whitespace removed
-static INLINE void rtrim(str *string)
-{
-	char *ptr;
-
-	ptr = string->s + string->len - 1;
-	while(string->len > 0 && (*ptr == 0 || isspace((int)*ptr))) {
-		string->len--;
-		ptr--;
-	}
-}
-
-// returns str with leading and trailing whitespace removed
-static INLINE void trim(str *string)
-{
-	ltrim(string);
-	rtrim(string);
-}
-
 static bool get_contact_uri(
 		struct sip_msg *msg, struct sip_uri *uri, contact_t **_c)
 {




More information about the sr-dev mailing list