[sr-dev] git:master:6f0b67b6: htable: fix a possible null pointer dereference in dmq startup error case

Henning Westerholt hw at skalatan.de
Fri May 31 12:43:47 CEST 2019


Module: kamailio
Branch: master
Commit: 6f0b67b675dd18dce60fa3e5a4ece063216bbab5
URL: https://github.com/kamailio/kamailio/commit/6f0b67b675dd18dce60fa3e5a4ece063216bbab5

Author: Henning Westerholt <hw at skalatan.de>
Committer: Henning Westerholt <hw at skalatan.de>
Date: 2019-05-31T12:42:21+02:00

htable: fix a possible null pointer dereference in dmq startup error case

---

Modified: src/modules/htable/ht_dmq.c

---

Diff:  https://github.com/kamailio/kamailio/commit/6f0b67b675dd18dce60fa3e5a4ece063216bbab5.diff
Patch: https://github.com/kamailio/kamailio/commit/6f0b67b675dd18dce60fa3e5a4ece063216bbab5.patch

---

diff --git a/src/modules/htable/ht_dmq.c b/src/modules/htable/ht_dmq.c
index 1f27e97684..26c6eb859a 100644
--- a/src/modules/htable/ht_dmq.c
+++ b/src/modules/htable/ht_dmq.c
@@ -588,11 +588,11 @@ int ht_dmq_handle_sync(srjson_doc_t* jdoc) {
 			if(ht==NULL) {
 				LM_WARN("unable to get table %.*s\n",
 						htname.len, (htname.s)?htname.s:"");
-			}
-
-			if (ht_set_cell_ex(ht, &cname, type, &val, 0, expire - now) < 0) {
-				LM_WARN("unable to set cell %.*s in table %.*s\n",
-						cname.len, cname.s, ht->name.len, ht->name.s);
+			} else {
+				if (ht_set_cell_ex(ht, &cname, type, &val, 0, expire - now) < 0) {
+					LM_WARN("unable to set cell %.*s in table %.*s\n",
+							cname.len, cname.s, ht->name.len, ht->name.s);
+				}
 			}
 		}
 




More information about the sr-dev mailing list