[sr-dev] git:master:26f68412: siptrace: avoid flooding logs with unnecessary errors on common scenarios

[Henning Westerholt]

Module: kamailio
Branch: master
Commit: 26f68412921323a6c681a14718f0091f42a44167
URL: https://github.com/kamailio/kamailio/commit/26f68412921323a6c681a14718f0091f42a44167

Author: iionita <ionut-razvan.ionita at 1and1.ro>
Committer: Henning Westerholt <henningw at users.noreply.github.com>
Date: 2019-05-28T21:56:25+02:00

siptrace: avoid flooding logs with unnecessary errors on common scenarios

---

Modified: src/modules/siptrace/siptrace.c

---

Diff:  https://github.com/kamailio/kamailio/commit/26f68412921323a6c681a14718f0091f42a44167.diff
Patch: https://github.com/kamailio/kamailio/commit/26f68412921323a6c681a14718f0091f42a44167.patch

---

diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c
index 95753610f7..8fa832a043 100644
--- a/src/modules/siptrace/siptrace.c
+++ b/src/modules/siptrace/siptrace.c
@@ -1814,13 +1814,18 @@ static void trace_dialog(struct dlg_cell* dlg, int type, struct dlg_cb_params *p
 	}
 
 	if (!(params->req->msg_flags & FL_SIPTRACE)) {
-		LM_ERR("Trace is off for this request...\n");
+		LM_DBG("Trace is off for this request...\n");
 		return;
 	}
 
 	xavp = xavp_get(&xavp_trace_info_name_s, NULL);
 	if (!xavp) {
-		LM_ERR("%.*s xavp not registered\n", xavp_trace_info_name_s.len,
+		/* this actually happens when only the transaction is traced
+		 * FL_SIPTRACE is set from trace_onreq_out
+		 * but xavp is set only for dialogs so this will avoid
+		 * registering dialog callbacks which is the desired behavior */
+		LM_DBG("%.*s xavp not registered! "
+				"Probably incoming E2E CANCEL!\n", xavp_trace_info_name_s.len,
 				xavp_trace_info_name_s.s);
 		return;
 	}