[sr-dev] [kamailio/kamailio] siptrace: use xavps to pass data for the duration of transaction/dialog (#1963)

Ionut Ionita notifications at github.com
Thu May 23 10:29:39 CEST 2019


I saw SR_XTYPE_DATA(if i'm not wrong) which gives you the possibility to have a free function but didn't use it because of the following:
* for transactions - no avps is used pointer is passed only using tm callbacks;
* for dialogs - as you're saying, dialog lifetime >> tranasaction, so i'm using DLGCB_TERMINATED free function to free the pointer; i'm using the avps only to pass data from sip_trace function to DLGCB_CREATED; 

I tested the code against leaks for the following scenarions: successfull call, kamailio generated dual bye, INVITE failed with 491 and CANCEL scenario. There are no leaks. If you have other scenarios in mind I'll be glad to try them out.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1963#issuecomment-495119647
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190523/8033ad2e/attachment.html>


More information about the sr-dev mailing list