[sr-dev] [kamailio/kamailio] After commit ce8d36f latency_limit_db requires us instead of ms (#1956)

Daniel-Constantin Mierla notifications at github.com
Fri May 17 22:32:42 CEST 2019


It is no regression as it was not working and it was expected to print what benchmark does when used in config file.

This features was added not to enclose each action in kamailio confg between a bm_start_time() and bm_log_time(), extended for db queries for better way to identify the slow operations.

So the actually expectation was to print micro-seconds as benchmakr does. Therefore multiplying with 1000 is not a proper fix here, it must stay microseconds in its base, with option to change if people want (or they expected) a different unit. That can be made default to miliseconds for old editions and let to microseconds for master branch. But I would go and ask in the community and see what most of them expected there as time unit.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1956#issuecomment-493590496
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190517/91ac9b34/attachment.html>


More information about the sr-dev mailing list