[sr-dev] [kamailio/kamailio] ims_qos: use msg_ctx_id_t to detect same msg/transaction processing (#1954)
Sergey Zyrianov
notifications at github.com
Wed May 15 13:20:20 CEST 2019
- relies on msg id and pid, not only msg id (which is incremeted by
each process and has potential conflicts with failure routing)
- msg id and pid are enough to indentify the transaction thus
dropping checks for the pointers
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #1613 (replace XXXX with an open issue number)
#### Description
Changed check to verify if response belongs to the saved request.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1954
-- Commit Summary --
* ims_qos: use msg_ctx_id_t to detect same msg/transaction processing
-- File Changes --
M src/modules/ims_qos/ims_qos_mod.c (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1954.patch
https://github.com/kamailio/kamailio/pull/1954.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1954
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190515/e6a861ec/attachment.html>
More information about the sr-dev
mailing list