[sr-dev] [kamailio/kamailio] Small fixes to dialplan module when an avp is used as subst_exp (#1914)

[Marco Capetta]

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->
If an AVP is used as subst_exp then each contained value is evaluated against the string.
In case a value doesn't match, a noisy error line was printed in the log. The patch fix this behavior in the following way:
 - printing just a debug line per each not matching value
 - printing an error line only if all the values fail the match

Additionally fixed the improper usage of match_exp instead of subst_exp when both values contain an AVP.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1914

-- Commit Summary --

  * dialplan: fixed avp usage in subst_exp field
  * dialplan: fixed error log in rule_translate

-- File Changes --

    M src/modules/dialplan/dp_repl.c (11)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1914.patch
https://github.com/kamailio/kamailio/pull/1914.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1914
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190328/596f4322/attachment-0001.html>