[sr-dev] [kamailio/kamailio] Makefile: give warning when old modules directory is found (#1891)

Mikko Lehto notifications at github.com
Wed Mar 13 21:44:17 CET 2019


For some reason, I sometimes have obsolete `modules` -subdirectory in top level source directory.
It seems to happen after going back and forth in Kamailio 4.x git branches and then back to 5.x.

When that happens, Makefile target "modules" does not correctly start building:
```
$ gmake modules
gmake: 'modules' is up to date.
```

Proposed patch tries to draw attention into such situation:
```
$ gmake modules
Makefile:14: "old Kamailio modules directory found, you should clean that"
gmake: 'modules' is up to date.
```

I think `git clean` could clean such leftovers but I am not brave enough to propose running that automatically.

Tested on FreeBSD 11.2 (GNU Make 4.2.1) and Ubuntu 16.04 (GNU Make 4.1).
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1891

-- Commit Summary --

  * Makefile: give warning when old modules directory is found

-- File Changes --

    M Makefile (3)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1891.patch
https://github.com/kamailio/kamailio/pull/1891.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1891
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190313/11ea4530/attachment.html>


More information about the sr-dev mailing list