[sr-dev] git:master:cd6ef63a: tm: remove unnecessary TMCB_ACK_NEG_IN callback call

iionita ionut-razvan.ionita at 1and1.ro
Wed Mar 13 14:28:25 CET 2019

Module: kamailio
Branch: master
Commit: cd6ef63a1eb5951ccb38276a91e150187702b352
URL: https://github.com/kamailio/kamailio/commit/cd6ef63a1eb5951ccb38276a91e150187702b352

Author: iionita <ionut-razvan.ionita at 1and1.ro>
Committer: iionita <ionut-razvan.ionita at 1and1.ro>
Date: 2019-03-12T16:19:01+02:00

tm: remove unnecessary TMCB_ACK_NEG_IN callback call

	- TMCB_ACK_NEG_IN was called in an if branch where the initial
condition was the message to be an INVITE; this was not affecting
anything for the moment since this callback wasn't used but in case
some piece of code would have used this callback it would be called
not only for hop-by-hop ACKs but also INVITEs

Closes #1871


Modified: src/modules/tm/t_reply.c


Diff:  https://github.com/kamailio/kamailio/commit/cd6ef63a1eb5951ccb38276a91e150187702b352.diff
Patch: https://github.com/kamailio/kamailio/commit/cd6ef63a1eb5951ccb38276a91e150187702b352.patch


diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c
index 33910e1f8c..202b8d826f 100644
--- a/src/modules/tm/t_reply.c
+++ b/src/modules/tm/t_reply.c
@@ -2303,14 +2303,6 @@ int reply_received( struct sip_msg  *p_msg )
 									t, &onsend_params);
-					if (unlikely(has_tran_tmcbs(t, TMCB_ACK_NEG_IN))){
-						INIT_TMCB_ONSEND_PARAMS(onsend_params,
-								t->uas.request, p_msg, &uac->request,
-								&uac->request.dst, ack, ack_len,
-								TMCB_LOCAL_F, branch, TYPE_LOCAL_ACK);
-						run_trans_callbacks_off_params(TMCB_ACK_NEG_IN,
-								t, &onsend_params);
-					}
 			} else if (is_local(t) /*&& 200 <= msg_status < 300*/) {

More information about the sr-dev mailing list