[sr-dev] [kamailio/kamailio] dialog module: option to choose between OPTIONS or INVITE on keep-alive (#1876)

Fernando S. Santos notifications at github.com
Fri Mar 1 20:12:31 CET 2019


<!--
Kamailio Project uses GitHub Issues only for bugs in the code or feature requests. Please use this template only for feature requests.

If you have questions about using Kamailio or related to its configuration file, ask on sr-users mailing list:

  * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

If you have questions about developing extensions to Kamailio or its existing C code, ask on sr-dev mailing list:

  * http://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue.

If you submit a feature request (or enhancement) add the description of what you would like to be added.

If there is no content to be filled in a section, the entire section can be removed.

You can delete the comments from the template sections when filling.

You can delete next line and everything above before submitting (it is a comment).
-->

### Description

Enable dialog module to user choose between INVITE or OPTIONS on send Re-INVITE on keep-alive

### Expected behavior

Make the dialog keep-alive through INVITE or OPTIONS. A user choice.

### Possible Solutions

In function dlg_send_ka of dlg_req_within.c:445, provide an option to choose the value from module config var, pv value, dlg flag, etc.

```
File: dlg_req_within.c

435    /* send keep-alive
436     * dlg - pointer to a struct dlg_cell
437     * dir - direction: the request will be sent to:
438     * 		DLG_CALLER_LEG (0): caller
439     * 		DLG_CALLEE_LEG (1): callee
440     */
441    int dlg_send_ka(dlg_cell_t *dlg, int dir)
442    {
443    	uac_req_t uac_r;
444    	dlg_t* di;
445    	str met = {"INVITE", 6};
446    	int result;
447    	dlg_iuid_t *iuid = NULL;
```

### Additional Information

Just for local tests, i changed dlg_req_within.c:445 from {"OPTIONS",7} to {"INVITE",6} and worked like a charm. I don't know if this change will affect other parts of kamailio.
Let me know if this change affect something else.

Thanks.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1876
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190301/3c8cf006/attachment.html>


More information about the sr-dev mailing list