[sr-dev] [kamailio/kamailio] kamctl: keep it POSIX (#1815)

micmac1 notifications at github.com
Sun Jan 20 09:56:56 CET 2019

Hi all,

I was trying to add entries to a remote database on OpenWrt and kamctl (address add ...) seemed to just hang there. A bit of digging showed that it prompted for a password, but I couldn't see it because it redirected the prompt to /dev/stderr, which doesn't exist on every system. This patch addresses thist.

Use portable "#!/bin/sh" shebang. This may still be a symlink to bash
(or some other shell).

Also replace the redirection to "/dev/stderr" with a POSIX redirection
to stderr. "/dev/stderr" is not available on all systems and is also not
recognized by all shells (example: ash). On systems without a working
"/dev/stderr" the user will not see the prompts etc.

Signed-off-by: Sebastian Kemper <sebastian_ml at gmx.net>

<!-- Kamailio Pull Request Template -->

  - for detailed contributing guidelines, read:
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * kamctl: keep it POSIX

-- File Changes --

    M utils/kamctl/kamctl (2)
    M utils/kamctl/kamctl.base (6)
    M utils/kamctl/kamctl.sqlbase (4)
    M utils/kamctl/kamdbctl (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190120/816d7f84/attachment.html>

More information about the sr-dev mailing list