[sr-dev] git:5.2:57017b10: presence: do not include presence.h in other header files

Daniel-Constantin Mierla miconda at gmail.com
Mon Jan 14 12:31:34 CET 2019


Module: kamailio
Branch: 5.2
Commit: 57017b10d9a50385368324beb7eef9044d0b124a
URL: https://github.com/kamailio/kamailio/commit/57017b10d9a50385368324beb7eef9044d0b124a

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2019-01-14T12:30:18+01:00

presence: do not include presence.h in other header files

- it exports as extern the module parameter variables and other modules built on
top of presence can end up including this header file, overwriting
declaration of variables with same name
- renamed db_url to pres_db_url, this being a common variable name, to
avoid same situation with a mistaken include in the future
- GH #1809

(cherry picked from commit eb1bf9a69abad3d237c136750fe8cacea4cd0a31)

---

Modified: src/modules/presence/hash.h
Modified: src/modules/presence/presence.c
Modified: src/modules/presence/presence.h
Modified: src/modules/presence/presence_dmq.c
Modified: src/modules/presence/presence_dmq.h
Modified: src/modules/presence/presentity.h
Modified: src/modules/presence/subscribe.h

---

Diff:  https://github.com/kamailio/kamailio/commit/57017b10d9a50385368324beb7eef9044d0b124a.diff
Patch: https://github.com/kamailio/kamailio/commit/57017b10d9a50385368324beb7eef9044d0b124a.patch




More information about the sr-dev mailing list