[sr-dev] git:5.0:3dcde884: cdp: fix three coverity errors (ressource leaks and error checks)

[Henning Westerholt]

Am Freitag, 11. Januar 2019, 17:06:45 CET schrieb Daniel-Constantin Mierla:
> in my opinion, I do not see any relevance in having the subject of the
> commit message to include a statement like:
> 
> ... fix N coverity errors ...
> 
> Who/what tool or how the issues were detected does not belong there, it
> can be added in the body, like when we mention who reported it or the
> number of the issue tracker. Even there I do not find it necessary, but
> can be added if one wants.
> 
> The subject should be related to what was fixed, it would be enough in
> this case:
> 
> cdp: fix resource leaks and error checks in peer_connect()
> 
> The subject should be as short as possible and concise, it is listed in
> the summary of the commits by various tools (e.g., tig) which are very
> useful when I do backports for stable releases or track what was changed
> during an interval of time.

Hi Daniel,

sure, It can be added in the body. And as you mentioned, it is not really 
important in the end how it was found.

Best regards,

Henning

-- 
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services
Kamailio security assessment - https://skalatan.de/de/assessment