[sr-dev] git:5.0:85e45ced: cdp: fix two errors from coverty scan (missing check, var initialization)

Henning Westerholt hw at kamailio.org
Fri Jan 11 16:18:49 CET 2019

Module: kamailio
Branch: 5.0
Commit: 85e45cede3c463fbe8186d19a8d7d024dd42cb76
URL: https://github.com/kamailio/kamailio/commit/85e45cede3c463fbe8186d19a8d7d024dd42cb76

Author: Henning Westerholt <hw at kamailio.org>
Committer: Henning Westerholt <hw at kamailio.org>
Date: 2019-01-11T16:10:57+01:00

cdp: fix two errors from coverty scan (missing check, var initialization)

- remove library call can fail, test for the error and log it
- initialize the msghdr variable with a memset

(cherry picked from commit 7d52bf6ce7188eaa57690766c231e55b5509db4f)


Modified: src/modules/cdp/receiver.c


Diff:  https://github.com/kamailio/kamailio/commit/85e45cede3c463fbe8186d19a8d7d024dd42cb76.diff
Patch: https://github.com/kamailio/kamailio/commit/85e45cede3c463fbe8186d19a8d7d024dd42cb76.patch


diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c
index 0ff2fe15ae..4162501f6c 100644
--- a/src/modules/cdp/receiver.c
+++ b/src/modules/cdp/receiver.c
@@ -157,10 +157,14 @@ static int make_send_pipe(serviced_peer_t *sp)
 static void close_send_pipe(serviced_peer_t *sp)
+	int tmp;
 	if (sp->send_pipe_name.s) {
-		remove(sp->send_pipe_name.s);
+		tmp = remove(sp->send_pipe_name.s);
+		if (tmp == -1) {
+			LM_ERR("could not remove send pipe\n");
+		}
@@ -269,6 +273,7 @@ static int send_fd(int pipe_fd,int fd, peer *p)
 	struct iovec iov[1];
 	int ret;
 	int *tmp = NULL;
+	memset(&msg, 0, sizeof(struct msghdr));
 	struct cmsghdr* cmsg;

More information about the sr-dev mailing list