[sr-dev] [kamailio/kamailio] secfilter: changed char* by str in RPC function params (#1787)

Daniel-Constantin Mierla notifications at github.com
Mon Jan 7 11:45:52 CET 2019


Just a side note for the future: passing structure variables as function parameters is not optimized if the structure is large (some compilers and static analyzers will complain). `str` is a small structure and it is fine, so not something that must to change here. Otherwise is recommended to pass the address (the pointer). What I mean is to have:

```
static int get_type(str *ctype)
```

instead of:

```
static int get_type(str ctype)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1787#issuecomment-451895137
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190107/c3ffb00d/attachment.html>


More information about the sr-dev mailing list