[sr-dev] [kamailio/kamailio] developing hiops module (#1856)

[Henning Westerholt]

Thank you for the your interest in Kamailio and the module in development. I did a quick high level look today and have a few comments:
- can you give a small description what your module actually does? :-)
- a huge part of your code is related to the asn1 functionality. Some of this is library code that could be maybe placed elsewhere, some of them is generated from a ASN1 definition. If you finished the development we should discuss how to deal with this. Maybe something can be also just add as a build dependency and don't need to be included.
- there is a cmake file inside, do you use cmake for something? In Kamailio we use standard make for building
- you just pushed a change to the htable module, this should be a separate pull request as its isolated from your module

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1856#issuecomment-466956126
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190225/c04be45f/attachment-0001.html>