[sr-dev] [kamailio/kamailio] developing hiops module (#1856)

[mojtabaesfandiari]

Hello,
Yes, Tell me about it.
I will do it as soon as.
I am far away right now. Actually i am going to Germany embassy.

On Wed, 20 Feb 2019, 14:15 Daniel-Constantin Mierla, <
notifications at github.com> wrote:

> There is no code for your module, it seems you try to add it as a git
> submodule. It has to be pushed with full code, if you want it to merge it
> inside kamailio repository.
>
> Then your commit messages do not follow the contributing guidelines:
>
>    -
>    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format
>
> I also suggest that you put the function you added in core to your module,
> it seems to target usage only there and there is no reason it doesn't work
> having it inside your module. If it needs to be used in other modules
> later, it can be relocated.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/kamailio/kamailio/pull/1856#issuecomment-465522509>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ArE2rGb76fmIyAZqmVh6E3u57X8b4_nAks5vPScsgaJpZM4a-_NY>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1856#issuecomment-465525720
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20190220/ebc966a8/attachment.html>