[sr-dev] [kamailio/kamailio] pv_headers: Initial commit (#2156)

Henning Westerholt notifications at github.com
Thu Dec 5 16:35:32 CET 2019


Interesting module addition, thank you for that. I just had a quick look today, as it is quite some code to read. :-) I noticed two things:

- some missing documentation (3.2 - 3.4) in the README, probably still to be added
- it makes probably sense to move the new str and del str functions to core/str.[h,c] and the str copy function to core/ut.h - what do you think?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2156#issuecomment-562182263
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20191205/ef119841/attachment.html>


More information about the sr-dev mailing list