[sr-dev] git:master:c10ab724: nsq: use snprintf() instead of sprintf()

Daniel-Constantin Mierla miconda at gmail.com
Mon Dec 2 16:26:40 CET 2019


Module: kamailio
Branch: master
Commit: c10ab724803cc084a00bab964dc1e2d582a0627b
URL: https://github.com/kamailio/kamailio/commit/c10ab724803cc084a00bab964dc1e2d582a0627b

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2019-12-02T16:21:25+01:00

nsq: use snprintf() instead of sprintf()

---

Modified: src/modules/nsq/nsq_reader.c

---

Diff:  https://github.com/kamailio/kamailio/commit/c10ab724803cc084a00bab964dc1e2d582a0627b.diff
Patch: https://github.com/kamailio/kamailio/commit/c10ab724803cc084a00bab964dc1e2d582a0627b.patch

---

diff --git a/src/modules/nsq/nsq_reader.c b/src/modules/nsq/nsq_reader.c
index 9a472ca8df..a8f403bda9 100644
--- a/src/modules/nsq/nsq_reader.c
+++ b/src/modules/nsq/nsq_reader.c
@@ -92,23 +92,23 @@ int nsq_consumer_event(char *payload, char *channel, char *topic)
 	json_api.extract_field(json_obj, k, &ev_name);
 	pkg_free(k);
 
-	sprintf(buffer, "nsq:consumer-event-%.*s-%.*s",ev_category.len, ev_category.s, ev_name.len, ev_name.s);
+	snprintf(buffer, 512, "nsq:consumer-event-%.*s-%.*s",ev_category.len, ev_category.s, ev_name.len, ev_name.s);
 	for (p=buffer ; *p; ++p) *p = tolower(*p);
 	for (p=buffer ; *p; ++p) if(*p == '_') *p = '-';
 	if (nsq_consumer_fire_event(buffer) != 0) {
-		sprintf(buffer, "nsq:consumer-event-%.*s", ev_category.len, ev_category.s);
+		snprintf(buffer, 512, "nsq:consumer-event-%.*s", ev_category.len, ev_category.s);
 		for (p=buffer ; *p; ++p) *p = tolower(*p);
 		for (p=buffer ; *p; ++p) if(*p == '_') *p = '-';
 		if (nsq_consumer_fire_event(buffer) != 0) {
-			sprintf(buffer, "nsq:consumer-event-%.*s-%.*s", nsq_event_key.len, nsq_event_key.s, nsq_event_sub_key.len, nsq_event_sub_key.s);
+			snprintf(buffer, 512, "nsq:consumer-event-%.*s-%.*s", nsq_event_key.len, nsq_event_key.s, nsq_event_sub_key.len, nsq_event_sub_key.s);
 			for (p=buffer ; *p; ++p) *p = tolower(*p);
 			for (p=buffer ; *p; ++p) if(*p == '_') *p = '-';
 			if (nsq_consumer_fire_event(buffer) != 0) {
-				sprintf(buffer, "nsq:consumer-event-%.*s", nsq_event_key.len, nsq_event_key.s);
+				snprintf(buffer, 512, "nsq:consumer-event-%.*s", nsq_event_key.len, nsq_event_key.s);
 				for (p=buffer ; *p; ++p) *p = tolower(*p);
 				for (p=buffer ; *p; ++p) if(*p == '_') *p = '-';
 				if (nsq_consumer_fire_event(buffer) != 0) {
-					sprintf(buffer, "nsq:consumer-event");
+					snprintf(buffer, 512, "nsq:consumer-event");
 					if (nsq_consumer_fire_event(buffer) != 0) {
 						LM_ERR("nsq:consumer-event not found");
 					}




More information about the sr-dev mailing list