[sr-dev] git:5.2:000e778c: topos_redis: fix regression in PRACK routing (commit cfc89db53c087, GH #1784)

[Henning Westerholt]

Module: kamailio
Branch: 5.2
Commit: 000e778cf8838989e316aa71f35f2e0e252c511d
URL: https://github.com/kamailio/kamailio/commit/000e778cf8838989e316aa71f35f2e0e252c511d

Author: Henning Westerholt <hw at skalatan.de>
Committer: Henning Westerholt <hw at skalatan.de>
Date: 2019-08-20T21:12:57+02:00

topos_redis: fix regression in PRACK routing (commit cfc89db53c087, GH #1784)

- fix regression in PRACK routing (introduced in cfc89db53c, GH #1784)
- result set were set to 0 before usage by a memset

(cherry picked from commit a263f5b62c03851a5d8a61f09e69745f90370703)

---

Modified: src/modules/topos_redis/topos_redis_storage.c

---

Diff:  https://github.com/kamailio/kamailio/commit/000e778cf8838989e316aa71f35f2e0e252c511d.diff
Patch: https://github.com/kamailio/kamailio/commit/000e778cf8838989e316aa71f35f2e0e252c511d.patch

---

diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c
index 47ddad0c1a..dd454935e1 100644
--- a/src/modules/topos_redis/topos_redis_storage.c
+++ b/src/modules/topos_redis/topos_redis_storage.c
@@ -727,6 +727,7 @@ int tps_redis_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd,
 	memset(argv, 0, TPS_REDIS_NR_KEYS * sizeof(char*));
 	memset(argvlen, 0, TPS_REDIS_NR_KEYS * sizeof(size_t));
 	argc = 0;
+	memset(&id, 0, sizeof(tps_data_t));
 
 	if(mode==0) {
 		/* load same transaction using Via branch */
@@ -737,7 +738,6 @@ int tps_redis_load_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd,
 			LM_ERR("failed to load the INVITE branch value\n");
 			return -1;
 		}
-		memset(&id, 0, sizeof(tps_data_t));
 		xvbranch1 = &id.x_vbranch1;
 	}
 	if(xvbranch1->len<=0 || xvbranch1->s==NULL) {