[sr-dev] git:master:ff1ce230: Merge pull request #1931 from ionutionita92/master

[GitHub]

Module: kamailio
Branch: master
Commit: ff1ce23083387e15cdd7dde5d5b59e5564d2409c
URL: https://github.com/kamailio/kamailio/commit/ff1ce23083387e15cdd7dde5d5b59e5564d2409c

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: GitHub <noreply at github.com>
Date: 2019-04-23T08:53:28+02:00

Merge pull request #1931 from ionutionita92/master

siptrace: safety check for tm callback parameter

---

Modified: src/modules/siptrace/siptrace.c

---

Diff:  https://github.com/kamailio/kamailio/commit/ff1ce23083387e15cdd7dde5d5b59e5564d2409c.diff
Patch: https://github.com/kamailio/kamailio/commit/ff1ce23083387e15cdd7dde5d5b59e5564d2409c.patch

---

diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c
index c34d25d249..e559d7874a 100644
--- a/src/modules/siptrace/siptrace.c
+++ b/src/modules/siptrace/siptrace.c
@@ -1956,6 +1956,12 @@ static void trace_dialog_transaction(struct dlg_cell* dlg, int type, struct dlg_
 		return;
 	}
 
+	/* coverity fix - there shouldn't be a scenario for this to happen */
+	if (params == NULL) {
+		LM_ERR("NULL tm params!\n");
+		return;
+	}
+
 	/**
 	 * DUAL BYE - internally generated BYE from kamailio
 	 * set flag to signal request_in callback which will register