[sr-dev] git:master:bd828828: More string buffer handling improvements in imc module

Jan Janak janakj at cs.columbia.edu
Sat Apr 20 18:27:11 CEST 2019


Module: kamailio
Branch: master
Commit: bd82882807ad89c7564709db414ddbe26bd70728
URL: https://github.com/kamailio/kamailio/commit/bd82882807ad89c7564709db414ddbe26bd70728

Author: Jan Janak <janakj at cs.columbia.edu>
Committer: Jan Janak <janakj at cs.columbia.edu>
Date: 2019-04-20T12:18:52-04:00

More string buffer handling improvements in imc module

Let the compiler do the work of figuring out the size of the string
buffer being written to using the sizeof operator. Hopefully, this
will make the source code less error-prone and more Coverity friendly.

Properly handle all return values of snprintf. In particular, do not
fail silently if the function returns -1.

---

Modified: src/modules/imc/imc_cmd.c

---

Diff:  https://github.com/kamailio/kamailio/commit/bd82882807ad89c7564709db414ddbe26bd70728.diff
Patch: https://github.com/kamailio/kamailio/commit/bd82882807ad89c7564709db414ddbe26bd70728.patch




More information about the sr-dev mailing list