[sr-dev] git:master:84a358d1: siptrace: remove unused trace flag

Henning Westerholt henningw at users.noreply.github.com
Tue Apr 9 21:26:03 CEST 2019


Module: kamailio
Branch: master
Commit: 84a358d143612544136bf34e9d6a369eb7547d4c
URL: https://github.com/kamailio/kamailio/commit/84a358d143612544136bf34e9d6a369eb7547d4c

Author: iionita <ionut-razvan.ionita at 1and1.ro>
Committer: Henning Westerholt <henningw at users.noreply.github.com>
Date: 2019-04-09T21:25:53+02:00

siptrace: remove unused trace flag

---

Modified: src/modules/siptrace/siptrace.c

---

Diff:  https://github.com/kamailio/kamailio/commit/84a358d143612544136bf34e9d6a369eb7547d4c.diff
Patch: https://github.com/kamailio/kamailio/commit/84a358d143612544136bf34e9d6a369eb7547d4c.patch

---

diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c
index fb6d4180e8..2f8f32a11f 100644
--- a/src/modules/siptrace/siptrace.c
+++ b/src/modules/siptrace/siptrace.c
@@ -132,7 +132,6 @@ static str siptrace_info_avp_str = str_init("$avp(__siptrace_info_avp__)");
 #define NR_KEYS 12
 #define SIP_TRACE_TABLE_VERSION 4
 
-int trace_flag = 0;
 int trace_on = 0;
 int trace_sl_acks = 1;
 
@@ -214,7 +213,6 @@ static param_export_t params[] = {
 	{"fromtag_column", PARAM_STR, &fromtag_column},
 	{"totag_column", PARAM_STR, &totag_column},
 	{"direction_column", PARAM_STR, &direction_column},
-	{"trace_flag", INT_PARAM, &trace_flag},
 	{"trace_on", INT_PARAM, &trace_on},
 	{"traced_user_avp", PARAM_STR, &traced_user_avp_str},
 	{"trace_table_avp", PARAM_STR, &trace_table_avp_str},
@@ -276,12 +274,6 @@ static int mod_init(void)
 		return -1;
 	}
 
-	if(trace_flag < 0 || trace_flag > (int)MAX_FLAG) {
-		LM_ERR("invalid trace flag %d\n", trace_flag);
-		return -1;
-	}
-	trace_flag = 1 << trace_flag;
-
 	trace_to_database_flag = (int *)shm_malloc(sizeof(int));
 	if(trace_to_database_flag == NULL) {
 		LM_ERR("no more shm memory left\n");




More information about the sr-dev mailing list