[sr-dev] git:master:8bc56bbc: ims_usrloc_scscf: fix compilation warning

Victor Seva linuxmaniac at torreviejawireless.org
Thu Sep 27 12:36:18 CEST 2018


Module: kamailio
Branch: master
Commit: 8bc56bbc23ef888ebbfbe54732ffe7f82bd7082d
URL: https://github.com/kamailio/kamailio/commit/8bc56bbc23ef888ebbfbe54732ffe7f82bd7082d

Author: Victor Seva <linuxmaniac at torreviejawireless.org>
Committer: Victor Seva <linuxmaniac at torreviejawireless.org>
Date: 2018-09-27T12:35:58+02:00

ims_usrloc_scscf: fix compilation warning

>impurecord.c:1243:16: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
>                if ((contact == impucontact->contact)) {
>                     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
>impurecord.c:1243:16: note: remove extraneous parentheses around the comparison to silence this warning
>                if ((contact == impucontact->contact)) {

---

Modified: src/modules/ims_usrloc_scscf/impurecord.c

---

Diff:  https://github.com/kamailio/kamailio/commit/8bc56bbc23ef888ebbfbe54732ffe7f82bd7082d.diff
Patch: https://github.com/kamailio/kamailio/commit/8bc56bbc23ef888ebbfbe54732ffe7f82bd7082d.patch

---

diff --git a/src/modules/ims_usrloc_scscf/impurecord.c b/src/modules/ims_usrloc_scscf/impurecord.c
index 20c8a64154..67744bb5db 100644
--- a/src/modules/ims_usrloc_scscf/impurecord.c
+++ b/src/modules/ims_usrloc_scscf/impurecord.c
@@ -1240,7 +1240,7 @@ int unlink_contact_from_impu(impurecord_t* impu, ucontact_t* contact, int write_
 	impucontact = impu->linked_contacts.head;
 	
 	while (impucontact) {
-		if ((contact == impucontact->contact)) {
+		if (contact == impucontact->contact) {
 			remove_impucontact_from_list(impu, impucontact);
 			if (write_to_db && db_mode == WRITE_THROUGH && (db_unlink_contact_from_impu(impu, contact) != 0)) {
 				LM_ERR("Failed to un-link DB contact [%.*s] from IMPU [%.*s]...continuing but db will be out of sync!\n", contact->c.len, contact->c.s, impu->public_identity.len, impu->public_identity.s);




More information about the sr-dev mailing list