[sr-dev] Pull request example

[Diego Nadares]

Thanks for your answer Henning. I  generated the following PR
<https://github.com/dnadares/kamailio/pull/1/commits/3dc61a0fadfc4e24db0cc5c8fdd70acdcd2644df>.
Please, let me know if its ok or if I should modify the template.

Cheers.

Diego.





El mié., 24 oct. 2018 a las 17:24, Henning Westerholt (<hw at kamailio.org>)
escribió:

> Am Mittwoch, 24. Oktober 2018, 16:48:51 CEST schrieb Diego Nadares:
> > I hit a little bug in evapi module. I would like to do a pull request
> but i
> > don't know exactly how to accomplish this.
> >
> > I found this howto -> https://yangsu.github.io/pull-request-tutorial .
> Are
> > these the correct steps?
> >
> > I tried but it's forbidden for my user.
> >
> > git checkout -b pull-request-demo
> > git push origin pull-request-demo
> >
> >
> > remote: Permission to kamailio/kamailio.git denied to dnadares.
> > fatal: unable to access 'https://github.com/kamailio/kamailio.git/': The
> > requested URL returned error: 403
> >
> > Could you help me, please?
>
> Hello Diego,
>
> as you don't have write access to the kamailio repository you need to
> "fork"
> it first. Then you do the changes in your own repository after check it
> out to
> your PC, and submit a pull request to our tracker. Have a look e.g. here:
>
> https://help.github.com/articles/fork-a-repo/
> https://help.github.com/articles/about-pull-requests/
>
> For generic development guidelines have a look to our wiki page:
>
> https://www.kamailio.org/wiki/devel/git-commit-guidelines
>
> Best regards,
>
> Henning
>
> --
> Henning Westerholt - https://skalatan.de/blog/
> Kamailio security assessment - https://skalatan.de/de/assessment
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20181024/addc9100/attachment.html>