[sr-dev] [kamailio/kamailio] acc: generating duplicates (#1674)

[Julien Chavanton]

on missed / failed calls issue #1673


#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [x] Breaking change (not tested with all scenarios, review could confirm that this is not introducing regressions)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #1673 

#### Description
problem with confusion when using  flags (integer value vs bit position value)
proposed solution is using the flags helpers functions `isflagset`, etc. where possible. 
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1674

-- Commit Summary --

  * acc: generating duplicates

-- File Changes --

    M src/modules/acc/acc.c (8)
    M src/modules/acc/acc_logic.c (5)
    M src/modules/acc_diameter/acc_diameter_mod.c (4)
    M src/modules/acc_json/acc_json_mod.c (4)
    M src/modules/acc_radius/acc_radius_mod.c (4)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1674.patch
https://github.com/kamailio/kamailio/pull/1674.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1674
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20181011/1db31750/attachment-0001.html>