[sr-dev] compiler warning

[Daniel-Constantin Mierla]

My remark was in context of your remark "It would be nice if people who
make commits would try to compile the code first." I am sure that Mikko
compiled and more than that it was made via a pull request, which was
compiled again by travis.

When making a stable release, it is cleaned up as much as possible from
warnings, also via coverity scan and static analysis. Among warnings,
unused variable is harmless and most compilers don't show it. Again, if
you use latest debian, you are seeing it, but older version of debian,
bsd, mac os, centos ... do not show it.

Cheers,
Daniel


On 02.10.18 12:26, Juha Heinanen wrote:
> Daniel-Constantin Mierla writes:
>
>> It is a matter of the OS, compiler and version if this kind of warning
>> is shown with the default flags. For example clang doesn't show it.
>> Latest versions of gcc do it.
> If clang does not show it, then the compile test should be done with
> gcc.  It is very bad policy if Kamailio project allows compiler warnings
> in the source code.
>
>> Also, the code is compiled by travis-ci, so if there is a compile error,
>> there will be an email alert on the sr-dev list.
> I don't know if travis-ci warns about unused variables.  If not, then
> it is useless in this regard.
>
> -- Juha
>
>

-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference -- www.kamailioworld.com
Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com