[sr-dev] git:master:18f7771a: ims_usrloc_pcscf: Update comment for free_security()

Tsvetomir Dimitrov tsv.dimitrov at gmail.com
Wed Jun 20 08:26:38 CEST 2018


Module: kamailio
Branch: master
Commit: 18f7771a8ce74e03b942a41095c6325f43ddb32f
URL: https://github.com/kamailio/kamailio/commit/18f7771a8ce74e03b942a41095c6325f43ddb32f

Author: Tsvetomir Dimitrov <tsv.dimitrov at gmail.com>
Committer: Tsvetomir Dimitrov <tsv.dimitrov at gmail.com>
Date: 2018-06-11T17:19:22+03:00

ims_usrloc_pcscf: Update comment for free_security()

---

Modified: src/modules/ims_usrloc_pcscf/pcontact.c

---

Diff:  https://github.com/kamailio/kamailio/commit/18f7771a8ce74e03b942a41095c6325f43ddb32f.diff
Patch: https://github.com/kamailio/kamailio/commit/18f7771a8ce74e03b942a41095c6325f43ddb32f.patch

---

diff --git a/src/modules/ims_usrloc_pcscf/pcontact.c b/src/modules/ims_usrloc_pcscf/pcontact.c
index 60d6b28132..76297bf1d9 100644
--- a/src/modules/ims_usrloc_pcscf/pcontact.c
+++ b/src/modules/ims_usrloc_pcscf/pcontact.c
@@ -112,6 +112,11 @@ void free_ppublic(ppublic_t* _p)
 	shm_free(_p);
 }
 
+
+// The same piece of code also lives in modules/ims_registrar_pcscf/sec_agree.c
+// Function - parse_sec_agree()
+// goto label - cleanup
+// Keep them in sync!
 void free_security(security_t* _p)
 {
     if (!_p)
@@ -137,8 +142,9 @@ void free_security(security_t* _p)
         case SECURITY_TLS:
             shm_free(_p->data.tls);
         break;
-
-        default: // Nothing to deallocate
+        
+        case SECURITY_NONE:
+            //Nothing to deallocate
         break;
     }
 




More information about the sr-dev mailing list