[sr-dev] git:5.1:df97c48f: ims_usrloc_scscf: assignment of length missing for query_buffer in

[Christoph Valentin]

Module: kamailio
Branch: 5.1
Commit: df97c48f94e8c8ce28ca0624bc3cfe4a86c89259
URL: https://github.com/kamailio/kamailio/commit/df97c48f94e8c8ce28ca0624bc3cfe4a86c89259

Author: Christoph Valentin <christoph.valentin at kapsch.net>
Committer: Christoph Valentin <christoph.valentin at kapsch.net>
Date: 2018-01-26T10:20:14+01:00

ims_usrloc_scscf: assignment of length missing for query_buffer in
db_link_contact_to_impu()

When writing to query_buffer with the help of the snprintf() function,
the result of the functio is written to variable query_buffer_len
instead of to the query_buffer.len itself. This leads to core dump
in some cases. Replaced "_" by "." in "query_buffer_len ="

(cherry picked from commit 11c179ab232222f1c78f19557032afd49bef7324)

---

Modified: src/modules/ims_usrloc_scscf/usrloc_db.c

---

Diff:  https://github.com/kamailio/kamailio/commit/df97c48f94e8c8ce28ca0624bc3cfe4a86c89259.diff
Patch: https://github.com/kamailio/kamailio/commit/df97c48f94e8c8ce28ca0624bc3cfe4a86c89259.patch

---

diff --git a/src/modules/ims_usrloc_scscf/usrloc_db.c b/src/modules/ims_usrloc_scscf/usrloc_db.c
index e1a7d4287e..b5301e0a3b 100644
--- a/src/modules/ims_usrloc_scscf/usrloc_db.c
+++ b/src/modules/ims_usrloc_scscf/usrloc_db.c
@@ -1079,7 +1079,7 @@ int db_link_contact_to_impu(impurecord_t* _r, ucontact_t* _c) {
 
     }
 
-    query_buffer_len = snprintf(query_buffer.s, query_buffer_len, impu_contact_insert_query, _r->public_identity.len, _r->public_identity.s, _c->c.len, _c->c.s);
+    query_buffer.len = snprintf(query_buffer.s, query_buffer_len, impu_contact_insert_query, _r->public_identity.len, _r->public_identity.s, _c->c.len, _c->c.s);
 
     LM_DBG("QUERY IS [%.*s] and len is %d\n", query_buffer.len, query_buffer.s, query_buffer.len);
     if (ul_dbf.raw_query(ul_dbh, &query_buffer, &rs) != 0) {