[sr-dev] git:master:cda1d086: pua: proper safety check on subs->extra_headers->s for subscribe_cbparam()

Daniel-Constantin Mierla miconda at gmail.com
Thu Jan 25 15:04:48 CET 2018


Module: kamailio
Branch: master
Commit: cda1d086c164052a5b79b54a8d0e5cf6e5fb3e1c
URL: https://github.com/kamailio/kamailio/commit/cda1d086c164052a5b79b54a8d0e5cf6e5fb3e1c

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2018-01-25T15:03:27+01:00

pua: proper safety check on subs->extra_headers->s for subscribe_cbparam()

- dicovered via GH PR #1409

---

Modified: src/modules/pua/send_subscribe.c

---

Diff:  https://github.com/kamailio/kamailio/commit/cda1d086c164052a5b79b54a8d0e5cf6e5fb3e1c.diff
Patch: https://github.com/kamailio/kamailio/commit/cda1d086c164052a5b79b54a8d0e5cf6e5fb3e1c.patch

---

diff --git a/src/modules/pua/send_subscribe.c b/src/modules/pua/send_subscribe.c
index b75290b936..254e77e7fd 100644
--- a/src/modules/pua/send_subscribe.c
+++ b/src/modules/pua/send_subscribe.c
@@ -821,7 +821,7 @@ ua_pres_t* subscribe_cbparam(subs_info_t* subs, int ua_flag)
 	{
 		CONT_COPY(hentity, hentity->id, subs->id);
 	}
-	if(subs->extra_headers && hentity->extra_headers->s)
+	if(subs->extra_headers && subs->extra_headers->s)
 	{
 		hentity->extra_headers= (str*)((char*)hentity+ size);
 		size+= sizeof(str);




More information about the sr-dev mailing list