[sr-dev] git:5.1:e9549e27: rls: removed local variable contact, unused inside rls_handle_subscribe()

Daniel-Constantin Mierla miconda at gmail.com
Mon Jan 22 11:30:31 CET 2018


Module: kamailio
Branch: 5.1
Commit: e9549e27efaf920e6f0b3d4c7a81129b705326e9
URL: https://github.com/kamailio/kamailio/commit/e9549e27efaf920e6f0b3d4c7a81129b705326e9

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2018-01-22T11:26:32+01:00

rls: removed local variable contact, unused inside rls_handle_subscribe()

(cherry picked from commit 2aebb2bf1f3d71a0dc7eca847af2aa127ff54453)

---

Modified: src/modules/rls/subscribe.c

---

Diff:  https://github.com/kamailio/kamailio/commit/e9549e27efaf920e6f0b3d4c7a81129b705326e9.diff
Patch: https://github.com/kamailio/kamailio/commit/e9549e27efaf920e6f0b3d4c7a81129b705326e9.patch

---

diff --git a/src/modules/rls/subscribe.c b/src/modules/rls/subscribe.c
index 9222dc72b8..a96d1674f7 100644
--- a/src/modules/rls/subscribe.c
+++ b/src/modules/rls/subscribe.c
@@ -479,7 +479,6 @@ int rls_handle_subscribe(struct sip_msg* msg, str watcher_user, str watcher_doma
 	pres_ev_t* event = NULL;
 	int err_ret = -1;
 	int ret = to_presence_code;
-	str* contact = NULL;
 	xmlDocPtr doc = NULL;
 	xmlNodePtr service_node = NULL;
 	unsigned int hash_code=0;
@@ -802,13 +801,6 @@ int rls_handle_subscribe(struct sip_msg* msg, str watcher_user, str watcher_doma
 	ret = 1;
 stop:
 forpresence:
-	if(contact!=NULL)
-	{
-		if(contact->s!=NULL)
-			pkg_free(contact->s);
-		pkg_free(contact);
-	}
-
 	if(subs.pres_uri.s!=NULL)
 		pkg_free(subs.pres_uri.s);
 	if(subs.record_route.s!=NULL)
@@ -829,13 +821,6 @@ int rls_handle_subscribe(struct sip_msg* msg, str watcher_user, str watcher_doma
 
 error:
 	LM_ERR("occurred in rls_handle_subscribe\n");
-
-	if(contact!=NULL)
-	{
-		if(contact->s!=NULL)
-			pkg_free(contact->s);
-		pkg_free(contact);
-	}
 	if(subs.pres_uri.s!=NULL)
 		pkg_free(subs.pres_uri.s);
 




More information about the sr-dev mailing list