[sr-dev] [kamailio/kamailio] kamctl: expose db root password variable used by kamdbctl.mysql in kamctlrc (3138051)

[Daniel-Constantin Mierla]

The purpose was exactly this one, to make visible as configuration option something that was not only in the functional code, but useful in various situation. Of course, it is bash and any variable can be set via environment, but it seemed not right to dig in the code to find internal stuff and see how one can overwrite it -- better make it explicit in the config file (and I also aligned it to the naming pattern for the rest of db vars).

It would be good from people/community to propose changes/enhancements when they need something and it is not a configuration option, otherwise a developer may not have an idea who is using some _hidden internal_ stuff.
Not really like that given is shell, but this would sound like: **in a C code blaming that a dev did a rename of a variable because someone does a sed to replace the old one before compilation with something else**.

Then I do not even remember when kamdbctl version was bumped, but was nothing like done periodically or on changes, but I agree could have been something good to do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/313805136d22ed79d1c4900753247032240d5a5b#commitcomment-26783803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180111/4f130d7f/attachment-0001.html>