[sr-dev] git:master:2bfb7147: CONTRIBUTING.md: added developer access section

Daniel-Constantin Mierla miconda at gmail.com
Sun Feb 18 10:36:02 CET 2018


Module: kamailio
Branch: master
Commit: 2bfb71472014cabf6a6fb0fdac1421d50486d775
URL: https://github.com/kamailio/kamailio/commit/2bfb71472014cabf6a6fb0fdac1421d50486d775

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2018-02-18T08:24:36+01:00

CONTRIBUTING.md: added developer access section

---

Modified: .github/CONTRIBUTING.md

---

Diff:  https://github.com/kamailio/kamailio/commit/2bfb71472014cabf6a6fb0fdac1421d50486d775.diff
Patch: https://github.com/kamailio/kamailio/commit/2bfb71472014cabf6a6fb0fdac1421d50486d775.patch

---

diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 1ac2f598e9..a09a8c0ef7 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -77,9 +77,6 @@ and commit history, there are several *rules* required for each contribution.
   * code **should** be formatted with **clang-format** or to match the style of
   the component that the commit applies to. The `.clang-format` file is part of
   Kamailio source code tree, in the root folder.
-  * personal branches of developers done inside Kamailio GIT repository must be
-  prefixed with `developerid/`, e.g., `alice/new-feature`. Do not use just
-  `new-feature` or `alice-new-feature` or other variant without `developerid/`.
 
 
 ### Commit Message Format ###
@@ -135,6 +132,25 @@ The above content about commit message format is taken from Kamailio wiki page:
   * https://www.kamailio.org/wiki/devel/git-commit-guidelines
   * it is recommended you read that one as well.
 
+### Developer Access ###
+
+  * developer access (commit rights) to Kamailio GIT repository is granted to
+  people that contribute relevant components (e.g., modules) or have consistent
+  contributions over a long interval of time
+  * each developer has to create an account on github.com portal. The
+  `developerid` is the username on github.com portal
+  * after getting developer access, it is still recommended to use pull request
+  for commits done to other components of Kamailio, to allow the main developer
+  of the component as well as the other developers to review the changes
+  * commits to own components can be pushed directly, without a pull request.
+  However, if the developer wants other people to review the changes, using a
+  pull request is the way to do it
+  * personal branches of developers done inside Kamailio GIT repository must be
+  prefixed with `developerid/`, e.g., `alice/new-feature`. Do not use just
+  `new-feature` or `alice-new-feature` or other variant without `developerid/`
+  * the [Contributions Basic Rules](#basic-rules) from the sections above have
+  to be followed as well after getting developer access
+
 ## Reporting Issues ##
 
 Whenever reporting an issue, along with the description of the problems, try to




More information about the sr-dev mailing list