[sr-dev] [kamailio/kamailio] schema: allow null value for active_watchers user-agent column (#1431)

Daniel-Constantin Mierla notifications at github.com
Thu Feb 8 13:49:12 CET 2018


Why the default value is no longer left to '' (empty string)? Allowing NULL should be ok also with having a default value.

Then, changing the database structure for this situation is not going to be backported, all updates of minor 5.0.x and 5.1.x will fail to just restart.

I think a better option is just to allow NULL, let the default to be '' and eventually fix in the code if there is a case in 5.0.x or 5.1.x when NULL is inserted and insert '' -- can you point in the code where the issue was exposed for you? Anyhow, this won't change the structure dramatically to require a version number update.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1431#issuecomment-364101887
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180208/b9d48623/attachment.html>


More information about the sr-dev mailing list