[sr-dev] [kamailio/kamailio] Modules: db_redis for usrloc module (#1422)

[Vadiml1024]

Vadiml1024 requested changes on this pull request.

I would suggest some rework:

This code contains potential reentrancy problems because
of strtok usage... should be using strtok_r

In lot of places it uses sprintf, strcat, and strcpy which are subject to potential buffer overflows

in some places i see snprintf where source string size is passed as 2 parameter (buffer size).  The idea is to pass target buffer size as second parameter 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1422#pullrequestreview-93862573
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180204/2065ccb1/attachment.html>