[sr-dev] git:master:6e6d82bc: secfilter: fix compilation warning

Jose Luis Verdeguer pepeluxx at gmail.com
Thu Dec 20 10:51:11 CET 2018


Module: kamailio
Branch: master
Commit: 6e6d82bc04a3f6a4744751b70dde8810a48838c5
URL: https://github.com/kamailio/kamailio/commit/6e6d82bc04a3f6a4744751b70dde8810a48838c5

Author: Victor Seva <linuxmaniac at torreviejawireless.org>
Committer: Jose Luis Verdeguer <pepeluxx at gmail.com>
Date: 2018-12-20T10:51:03+01:00

secfilter: fix compilation warning

> secfilter.c:516:15: warning: comparison of address of 'msg->rcv.src_ip' equal to a null pointer is always false [-Wtautological-pointer-compare]
>        if(&msg->rcv.src_ip == NULL)
>            ~~~~~~~~~^~~~~~    ~~~~
> 1 warning generated.

---

Modified: src/modules/secfilter/secfilter.c

---

Diff:  https://github.com/kamailio/kamailio/commit/6e6d82bc04a3f6a4744751b70dde8810a48838c5.diff
Patch: https://github.com/kamailio/kamailio/commit/6e6d82bc04a3f6a4744751b70dde8810a48838c5.patch

---

diff --git a/src/modules/secfilter/secfilter.c b/src/modules/secfilter/secfilter.c
index 94d592e434..2b5b91d84e 100644
--- a/src/modules/secfilter/secfilter.c
+++ b/src/modules/secfilter/secfilter.c
@@ -513,8 +513,6 @@ static int w_check_ip(struct sip_msg *msg)
 
 	if(msg == NULL)
 		return -1;
-	if(&msg->rcv.src_ip == NULL)
-		return -1;
 
 	ip.s = ip_addr2a(&msg->rcv.src_ip);
 	ip.len = strlen(ip.s);




More information about the sr-dev mailing list