[sr-dev] [kamailio/kamailio] core: Add PROXY protocol implementation (#1765)

[Henning Westerholt]

Thank you for the comments and extensions. About this question:

> related to error cases, what would happen if you e.g. set in the IPv6 case 0x21 the dst_ip->af = 
> AF_INET6, but later one run unto an error in the parsing. Then you would return an error to the 
> callee, and would go to the read_ip_info path. Here the AF_INET6 would be still be set, or I am 
> wrong?

I probably should formulated it better. My more general questions would be: are there error conditions that could occur during the proxy header parsing that could leave the Kamailio core with some (socket) data from the proxy protocol, and some data from the normal parsing? I am asking especially as this would be a classical border condition that could lead to e.g. some security issue.

Otherwise the code also for me looks ready to merge. Please add some documentation about this new core parameter in the wiki core cookbook (https://www.kamailio.org/wiki/cookbooks/devel/core).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1765#issuecomment-448504071
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20181219/b2260a28/attachment.html>