[sr-dev] [kamailio/kamailio] http_client: http_connect_raw (#1763)

Julien Chavanton notifications at github.com
Tue Dec 11 22:13:45 CET 2018


similar to http_connect for http/post, however the data parameter is not PV parsed
this way json and any other content can be used without any escaping

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
I have ran into the issue, where a dollar sign was present in the data  : 

https://lists.kamailio.org/pipermail/sr-dev/2009-March/000898.html
```
Try to replace $ with $$ inside the $var(data), something like:

$var(m) = "$";
$var(r) = "$$";
$var(newdata) = $(var(data){s.replace,$var(m),$var(r)});
```
This fix is working, but I thought others could fell into this pitfall and have builtin way to send raw data over http could be best.

By adding a module command to send `http_connect_raw()`

I wonder if this should be called something else ...
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1763

-- Commit Summary --

  * http_client: http_connect_raw

-- File Changes --

    M src/modules/http_client/doc/http_client_admin.xml (63)
    M src/modules/http_client/http_client.c (99)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1763.patch
https://github.com/kamailio/kamailio/pull/1763.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1763
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20181211/14b0bf95/attachment.html>


More information about the sr-dev mailing list