[sr-dev] [kamailio/kamailio] dmq: add optional parameter to dmq_handle_message() (#1626)

[Charles Chance]

Very cool!

It is definitely useful. However, I have one very small comment.

I'm not sure what value it adds allowing the config to determine the returned value - only that the function returns without exiting. Possibly just semantics right now, but it could potentially restrict future module development - or not, but better to be safe.

Would it still serve its purpose if the parameter was renamed to something like "return" or "continue" and only return 1 if set or 0 if not?

Again, nice use case :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1626#issuecomment-417745593
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20180831/d6c78e37/attachment.html>