[sr-dev] git:master:352440d2: ims_charging: fixed check result code at mscc level (#1504)

Daniel-Constantin Mierla miconda at gmail.com
Tue Apr 24 12:39:13 CEST 2018


Module: kamailio
Branch: master
Commit: 352440d299f1b9f431cc05397f4ea6a7b5967c8a
URL: https://github.com/kamailio/kamailio/commit/352440d299f1b9f431cc05397f4ea6a7b5967c8a

Author: yuri-r <yuri.rootshtein at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2018-04-24T12:39:07+02:00

ims_charging: fixed check result code at mscc level (#1504)

* ims_charging: fixed check result code at mscc level

according to RFC 4006 the Result-Code in Multiple-Services-Credit-Control AVP is optional.
resume_on_initial_ccr() stops proceeding CCA if no Result-Code in MSCC and goes to error1 even though
the Result-Code on CCR itself is 2001 (SUCCESSFUL)

* ims_charging: fixed check result code at mscc level

according to RFC 4006 the Result-Code in Multiple-Services-Credit-Control AVP is optional.
resume_on_initial_ccr() stops proceeding CCA if no Result-Code in MSCC and goes to error1 even though
the Result-Code on CCR itself is 2001 (SUCCESSFUL)

---

Modified: src/modules/ims_charging/ims_ro.c

---

Diff:  https://github.com/kamailio/kamailio/commit/352440d299f1b9f431cc05397f4ea6a7b5967c8a.diff
Patch: https://github.com/kamailio/kamailio/commit/352440d299f1b9f431cc05397f4ea6a7b5967c8a.patch

---

diff --git a/src/modules/ims_charging/ims_ro.c b/src/modules/ims_charging/ims_ro.c
index 735f5b30be..497f65dd72 100644
--- a/src/modules/ims_charging/ims_ro.c
+++ b/src/modules/ims_charging/ims_ro.c
@@ -1361,7 +1361,7 @@ static void resume_on_initial_ccr(int is_timeout, void *param, AAAMessage *cca,
 	create_cca_fui_avps(fui_action, redirecturi);
 	
 	/* check result code at mscc level */
-	if (ro_cca_data->mscc->resultcode != 2001) {
+	if (ro_cca_data->mscc->resultcode && ro_cca_data->mscc->resultcode != 2001) {
 		LM_DBG("CCA failure at MSCC level with resultcode [%d]\n", ro_cca_data->mscc->resultcode);
 		error_code = RO_RETURN_FALSE;
         goto error1;




More information about the sr-dev mailing list