[sr-dev] [kamailio/kamailio] pkg/kamailio/obs: Updated obs spec (#1241)

Daniel-Constantin Mierla notifications at github.com
Fri Sep 22 09:34:56 CEST 2017


Thanks for the PR and your significant contributions to rpm packaging.

But again I have to say that I am not confident the (sym)linking to obs folder is the right solution for other distributions. obs itself is by design an packing system for many distros. Just storing in the repo symlinks is creating some relations that should not be placed there.

As an idea that popped up right now in my mind, maybe it is better to have the folder rhel with a README.md and a Makefile inside. The makefile will have some rules to create subfolders for rhel versions (e.g., 6, 7...) that can be symlinks to obs if that works for packaging. The readme will explain that. Then the symlinks are created on the local copy of the person in need to do the packaging.

I know that there is a symlink for one of the packaging specs, but I find it confusing and not necessary to store it in the repo, being something needed to be created temporary.

Maybe we can discuss more during the irc devel meeting:

  * https://www.kamailio.org/wiki/devel/irc-meetings/2017b

To conclude: I am fine to merge your updates, but remove those symlinking, let's discuss in the community how to do that properly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1241#issuecomment-331373764
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20170922/1de80a8b/attachment.html>


More information about the sr-dev mailing list