[sr-dev] [kamailio/kamailio] define flag_t as unsigned long (#1288)

Daniel-Constantin Mierla notifications at github.com
Mon Oct 30 10:51:34 CET 2017


This has implications on other parts, such as variables where they can be accessed and set via $mf (iirc).

On the other hand, I don't think having a variable with different lengths is a good approach, because it can break easily config behaviour when moving from one server to another. It should be same size on 32b or 64b, so if a change to increase the size is to be done, then should be `long long` to ensure it is 64 on all archs. An alternative would be to make the field inside sip_msg_t an array of flag_t values, so can be one or more, even beyond 64b. But this change will have also impact in other parts, therefore would need careful review.

As an alternative for now would be using an avp or xavps, and do bitwise operations (`|` and `&`) to set or test.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1288#issuecomment-340394835
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20171030/6f600861/attachment.html>


More information about the sr-dev mailing list