[sr-dev] [kamailio/kamailio] tsilo: deadlock in ts_append() (#1138)

Federico Cabiddu notifications at github.com
Fri May 26 11:30:34 CEST 2017


grumvalski commented on this pull request.



> @@ -250,15 +250,25 @@ static int fixup_ts_append(void** param, int param_no)
  */
 static int w_ts_append(struct sip_msg* _msg, char *_table, char *_ruri)
 {
-	str ruri = {0};
+	str tmp  = STR_NULL;

I think this change should be done into ts_append, not in the wrapper. What can be changed by branch routes is the  ruri that you pass to ts_append, so saving the original one at this level wouldn't solve the issue, if I'm not wrong.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1138#pullrequestreview-40480683
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20170526/93a76dc4/attachment.html>


More information about the sr-dev mailing list